Prevent a possible nil object from being inserted into an NSDictionary.

NYPL-Simplified · Mar 20, 2019 · d73b572 · d73b572
1 parent 060f8a3
commit d73b572
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/Simplified/NYPLOPDSFeed.m b/Simplified/NYPLOPDSFeed.m
@@ -110,8 +110,14 @@ - (instancetype)initWithXML:(NYPLXML *const)feedXML
   // Sometimes we get back JUST an entry, and in that case we just want to construct a feed with
   // nothing set other than the entry.
   if ([feedXML.name isEqual:@"entry"]) {
-    self.entries = @[[[NYPLOPDSEntry alloc] initWithXML:feedXML]];
-    return self;
+    NYPLOPDSEntry const* entry = [[NYPLOPDSEntry alloc] initWithXML:feedXML];
+    if (entry) {
+      self.entries = @[entry];
+      return self;
+    } else {
+      NYPLLOG(@"Error creating single OPDS entry from feed.");
+      return nil;
+    }
   }
 
   if(!((self.identifier = [feedXML firstChildWithName:@"id"].value))) {