Email/Keyboard Support Per Library #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
would not kick off switching to the correct catalog after choosing SimplyE Collection on the Welcome Screen.
handling for new keys in the object.
and pin fields have the same four possible cases. Only the pin field will use "none" to also mean that a pin is not required. However, the requirement of a username/id field is NOT dependent on the keyboard value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing deprecated SimplyE keys being used prior to 2.0(multi-library).
Support for email sign in + any type of keyboard specified by the registry for username and pin fields.
NOTE: Pin == NONE also implies "no pin required". No such implication exists for the username/patron ID field.
Also address issue that caused a new library selection, from a fresh install, to potentially not fully load in until the next app-open.