iOS-584 Disable ipa upload to firebase #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ettore
approved these changes
Nov 8, 2023
ExplorerNautilus
force-pushed
the
iOS-584
branch
from
5924ec0
to
8d3abf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
Disable ipa upload to firebase due to error
Why are we doing this? (w/ JIRA link if applicable)
Firebase authentication is deprecated and we'll be using TestFlight instead
How should this be tested? / Do these changes have associated tests?
N/A
Dependencies for merging? Releasing to production?
N/A
Does this include changes that require a new SimplyE/Open eBooks build for QA?
N/A
Has the application documentation been updated for these changes?
Yes
Did someone actually run this code to verify it works?
Will be tested on CI