NOREF Limit requests handled by workers #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update introduces two configuration settings for our gunicorn server: - `max_requests` Limits the number of total requests that can be handled by a single gunicorn worker. The gunicorn docs state this is intended to help limit effects of memory leaks - `max_requests_jitter` This randomizes the exact number of requests to prevent multiple workers from being restarted simultaneously The goal of this work is to hopefully limit memory consumption (which tends to run at 90% or greater in production) and to reduce the effect of `QueuePool` errors that result from long-running workers. At the current setting of 500 this should result in workers being restarted roughly every 45-60 minutes. This can be adjusted after review of effects on performance in QA (and production if no issues are raised in QA).
These values (500 and 50) should give us the desired performance in production.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1901 +/- ##
========================================
Coverage 92.56% 92.56%
========================================
Files 216 216
Lines 43647 43648 +1
========================================
+ Hits 40400 40401 +1
Misses 3247 3247
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces two configuration settings for our gunicorn server:
max_requestsLimits the number of total requests that can be handled by a single gunicorn worker. The gunicorn docs state this is intended to help limit effects of memory leaksmax_requests_jitterThis randomizes the exact number of requests to prevent multiple workers from being restarted simultaneouslyThe goal of this work is to hopefully limit memory consumption (which tends to run at 90% or greater in production) and to reduce the effect of
QueuePoolerrors that result from long-running workers. At the current setting of 500 this should result in workers being restarted roughly every 45-60 minutes. This can be adjusted after review of effects on performance in QA (and production if no issues are raised in QA).