This repository has been archived by the owner on Apr 11, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gh that we can rely on them always.
…ks at 'featured' items on lists.
… library admin, not an automatic decision based on how many books are in the lane.
…r to work around Gutenberg filtering in tests.
…'Everything' lane, and changed query_works argument names to match how we're calling it.
…dren's Informational Books)
…ing a Lane will create a WorkList with some of the Lane's restrictions, unless it's the root for a patron type.
Database lanes updates
aslagle
reviewed
Nov 3, 2017
@@ -0,0 +1 @@ | |||
drop table cachedfeeds; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should update the date of this migration before merging.
… we don't need to make people come up with an identifier separate from the display name.
…ble description of a lane.
Remove lane identifier
…es for its children.
…he grouped list to groups() itself.
…ated with the parent lane.
Make sure a lane's groups feed includes that lane's paginated feed as a group
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch replaces the old
Lane
class with a newLane
class that's an ORM object. The features of the old lanes are still available, with the following exceptions:inherit_parent_restrictions
. If this is set, a Work will only show up in a Lane if it would have also shown up in the parent lane. This works even when one or both Lanes are based on CustomList membership.The
LaneList
class has been removed, as have the various subclasses ofLane
. Both of these are replaced by theWorkList
class, a generic implementation of "something that can obtain a bunch of Works on demand, and also might have children that are alsoWorkList
s". TheLane
class usesWorkList
as a mixin.Other notable changes:
Work
as itswork_model
. Now you have to use a materialized view. Although theWork
feature was originally how this whole thing worked before we created materialized views, at this point it was only used in tests and it made the code significantly more complicated.This is the basis for a new feature branch, so I won't be merging it immediately after the PR is approved.