Dashboard Facelift #524
Closed
Dashboard Facelift #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Few months late, but thanks for sharing this! I like the dashboard styling, and the housekeeping and new worker routes on api.py are cool too. Similar motivations to you, I'm partial to keeping the JS within a framework I already sort-of know (Vue.js). I'm going to work on merging in a lot of this though. |
deargle
added a commit
that referenced
this pull request
Oct 1, 2021
First pass at extracting just the API changes from #524
deargle
reviewed
Oct 2, 2021
psiturk/dashboard/__init__.py
Outdated
| '\nRefusing to start.' | ||
| )) | ||
| login_manager.init_app(app) | ||
| with app.app_context(): |
deargle
reviewed
Oct 2, 2021
psiturk/api/__init__.py
Outdated
|
|
||
| # POST: Set the services manager mode | ||
| # mode: live or sandbox, the desired mode | ||
| def post(self): |
There was a problem hiding this comment.
I'm uncomfortable with this -- I think the api shouldn't have any inherent concept of a session. The dashboard, on the other hand, can conceptually know about a session.
There was a problem hiding this comment.
On the other hand, my argument above probably means that the api shouldn't know about any services_manager either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mentioned in an issue so I figured I'd create a PR so more people are aware of a restyling of the dashboard I've been developing and using with my lab. It seeks to solve the overflowing layout problems and responsiveness that exist in the current dashboard, and bring web browser functionality up to par with the CLI's capabilities. It's been super useful so far, especially for our lab manager and members who are far more comfortable in a browser interface than in a shell.
Unlike the previous dashboard which used Vue.js, this one is pure vanilla JS, powered mostly by a data viewport module I built a couple years ago and revamped here in dbview.js and dbfilter.js. The central layout on each page is the database and filter viewport on which you can apply any column-based comparative filters you want, and then a more customized pane depending on the functionality of the page. Actions like approval and bonusing can either be performed individually or on the visible rows in the database viewport. Said actions are handled in modals, as seen in the screenshots attached.
It should be comfortably responsive, and has worked well on my phone, but I have yet to test on a higher resolution than my laptop.