Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework user sessions system #3000

Merged
merged 9 commits into from
Aug 13, 2022
Merged

Rework user sessions system #3000

merged 9 commits into from
Aug 13, 2022

Conversation

partydragen
Copy link
Member

@partydragen partydragen commented Aug 7, 2022

Tasks:

  • Switch session to use hash
  • Logout all other hashes when user changing password and enables tfa
  • Update database
  • Add new UserCP page to view sessions

@partydragen partydragen changed the base branch from v2 to release/2.0.2 August 7, 2022 14:48
@partydragen partydragen changed the title Move user sessions to use hash instead Rework user sessions system Aug 7, 2022
@tadhgboyle
Copy link
Member

Two comments:

  • "Add new UserCP page to view sessions"; this means we will require templates to update, meaning it will have to be in a major 2.x.0 update
  • Is it possible to store the login method in the sessions table? Would be neat if we could display how they logged in on each of their active sessions!

@partydragen
Copy link
Member Author

Two comments:

  • "Add new UserCP page to view sessions"; this means we will require templates to update, meaning it will have to be in a major 2.x.0 update
  • Is it possible to store the login method in the sessions table? Would be neat if we could display how they logged in on each of their active sessions!
  1. Not really a breaking change but people need to update their templates yea, at the same time this is a security feature with make it important, Lets see what Sam says

  2. Should be possible yea by using the existing method param with show username/email/oauth atleast

@partydragen partydragen marked this pull request as ready for review August 11, 2022 14:02
core/classes/Core/User.php Outdated Show resolved Hide resolved
core/init.php Outdated Show resolved Hide resolved
modules/Core/pages/user/settings.php Show resolved Hide resolved
core/classes/Core/User.php Outdated Show resolved Hide resolved
core/classes/Core/User.php Show resolved Hide resolved
@tadhgboyle
Copy link
Member

Is displaying the sessions in StaffCP delayed as well, or will that be added to this PR?

@partydragen
Copy link
Member Author

Is displaying the sessions in StaffCP delayed as well, or will that be added to this PR?

Delayed so pr is done

@supercrafter100
Copy link
Member

Im guessing everything has been tested and confirmed working?

@partydragen
Copy link
Member Author

Im guessing everything has been tested and confirmed working?

Have tested yea, was not really that major changes and is only installer, login, re-auth and oauth that using login and its all using the user login function so it worked everywhere by my testing, the changes itself is pretty simple

@tadhgboyle tadhgboyle merged commit 469bebc into release/2.0.2 Aug 13, 2022
@tadhgboyle tadhgboyle deleted the concept/users-session branch August 13, 2022 04:29
@Derkades Derkades added this to the 2.0.x milestone Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants