Remove null in rss feed when no address in meetup #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripoul
requested review from
bdeglane,
charlyx,
frinyvonnick and
mcampourcy
as code owners
|
👷 Deploy request for kind-hoover-e61df1 pending review. 🔨 Explore the source changes: 319f072 |
charlyx
approved these changes
Jun 10, 2021
| @@ -22,7 +22,7 @@ const formatContent = ({ | |||
| <p>${t.description}</p> | |||
| <p>Par:</p> | |||
| <ul> | |||
| ${t.speakers.reduce((b, s) => isUrl(s.link) ? (`${b}<li><a href="${s.link}">${s.name}</a></li>`) : | |||
| ${t.speakers.reduce((b, s) => isUrl(s.link) ? (`${b}<li><a href="${s.link}">${s.name}</a></li>`) : | |||
There was a problem hiding this comment.
I can't see any difference?
There was a problem hiding this comment.
The space at the end. It's my linter who did it. I can re-add it.
rss.js
Outdated
| @@ -37,7 +37,7 @@ const formatContent = ({ | |||
| } = venue; | |||
| const location = ` | |||
| ${link ? `<a href="${link}">${name}</a>`: name}<br/> | |||
| ${address} ${postal_code} ${city} | |||
| ${address ? `${address}` : ""} ${postal_code ? `${postal_code}` : ""} ${city ? `${city}` : ""} | |||
There was a problem hiding this comment.
Suggested change
| ${address ? `${address}` : ""} ${postal_code ? `${postal_code}` : ""} ${city ? `${city}` : ""} | |
| ${address ?? ""} ${postal_code ?? ""} ${city ?? ""} |
There was a problem hiding this comment.
thx didn't know the ?? in js
Co-authored-by: Charles-Henri GUERIN <charleshenri.guerin@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the covid strike too hard, we have to do our meeting remotely. In this case, in the rss feed, the address is displayed as
null null null. https://i.imgur.com/9r9IKIn.png