CraterCrashGH-143 Return null rather than 0-sized property info list

Naros · Mar 8, 2024 · 300caeb · 300caeb
1 parent 290f57e
commit 300caeb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/script/instances/script_instance.cpp b/src/script/instances/script_instance.cpp
@@ -218,6 +218,9 @@ GDExtensionPropertyInfo* OScriptInstance::get_property_list(uint32_t* r_count)
     }
 
     *r_count = infos.size();
+    if (infos.size() == 0)
+        return nullptr;
+
     GDExtensionPropertyInfo* list = MemoryUtils::memnew_with_size<GDExtensionPropertyInfo>(infos.size());
     memcpy(list, infos.ptr(), sizeof(GDExtensionPropertyInfo) * infos.size());
     return list;

diff --git a/src/script/instances/script_instance_placeholder.cpp b/src/script/instances/script_instance_placeholder.cpp
@@ -188,6 +188,9 @@ GDExtensionPropertyInfo* OScriptPlaceHolderInstance::get_property_list(uint32_t*
 
     *r_count = infos.size();
 
+    if (infos.size() == 0)
+        return nullptr;
+
     GDExtensionPropertyInfo* list = MemoryUtils::memnew_with_size<GDExtensionPropertyInfo>(infos.size());
     memcpy(list, infos.ptr(), sizeof(GDExtensionPropertyInfo) * infos.size());