Enable enr field in GetPeers and GetPeerById (#8641) #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Expose discovery NodeId to DiscoveryPeer and LibP2PPeer (Consensys#38) * Add DiscoveryPeer.getNodeId() * Add Eth2Peer.getDiscoveryNodeId() method. * Refactoring, discovery updated to 24.9.1 --------- Co-authored-by: Anton Nashatyrev <Nashatyrev@users.noreply.github.com>
Nashatyrev
reviewed
Oct 1, 2024
| import java.util.Optional; | ||
| import tech.pegasys.teku.networking.eth2.peers.Eth2Peer; | ||
|
|
||
| public record Eth2PeerWithEnr(Eth2Peer peer, Optional<String> enr) {} |
There was a problem hiding this comment.
As the enr is optional, does it make sense to just add this field to EthPeer?
Nashatyrev
reviewed
Oct 1, 2024
| import org.apache.tuweni.units.bigints.UInt256; | ||
| import tech.pegasys.teku.networking.p2p.peer.Peer; | ||
|
|
||
| public interface DiscoveryNodeIdExtractor { | ||
| UInt256 calculateDiscoveryNodeId(Peer peer); | ||
| Optional<UInt256> calculateDiscoveryNodeId(Peer peer); |
There was a problem hiding this comment.
For Libp2pPeer the nodeId would always exist. We have no other Peer implementations aside of libp2p. Do we really need to handle hypothetical case of absent NodeId ?
Nashatyrev
approved these changes
Oct 1, 2024
|
Decided to not get too far from master and keep it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from master