Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove loadvoc CLI command and related tests #623

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Conversation

osma
Copy link
Member

@osma osma commented Sep 23, 2022

This PR removes the annif loadvoc command which was deprecated in PR #614 but still available in the Annif 0.59 release but scheduled for removal in 0.59. The load-vocab command should be used instead.

@osma osma added this to the 0.60 milestone Sep 23, 2022
@osma osma self-assigned this Sep 23, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 99.61% // Head: 99.61% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (584b501) compared to base (ec10014).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
- Coverage   99.61%   99.61%   -0.01%     
==========================================
  Files          87       87              
  Lines        6038     5945      -93     
==========================================
- Hits         6015     5922      -93     
  Misses         23       23              
Impacted Files Coverage Δ
annif/cli.py 99.67% <ø> (-0.02%) ⬇️
tests/test_cli.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@osma
Copy link
Member Author

osma commented Sep 23, 2022

All seems well in CI so I'll merge this.

@osma osma merged commit daeec49 into master Sep 23, 2022
@osma osma deleted the remove-loadvoc-command branch September 23, 2022 09:44
@osma osma mentioned this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant