Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript error on hierarchy sort #1270

Closed
joelit opened this issue Feb 11, 2022 · 3 comments · Fixed by #1316
Closed

JavaScript error on hierarchy sort #1270

joelit opened this issue Feb 11, 2022 · 3 comments · Fixed by #1316
Assignees
@osma
Labels
bug needs backport
Milestone
2.15

Comments

@joelit
Copy link
Contributor

joelit commented Feb 11, 2022 •
edited
Loading

At which URL did you encounter the problem?

https://dev.finto.fi/iptc/fi/index

What steps will reproduce the problem?

  1. Open console to see error messages
  2. Select the Hierarchy tab on the left-hand sidebar
  3. UI will say hierarchy is loading, the error log will say that hierarchy.js crashes with
    Uncaught Error: Syntax error, unrecognized expression: iptc newscodes: scene

What is the expected output? What do you see instead?

We should get the IPTC hierarchy sorted according to the configured notation
@joelit
Copy link
Contributor Author

joelit commented Feb 11, 2022

This issue could be related to IPTC having two concept schemes - http://cv.iptc.org/newscodes/scene/ and http://cv.iptc.org/newscodes/subjectcode/

@joelit joelit added the bug label Feb 11, 2022
@osma osma moved this to Proposed items for this sprint in Finton Skosmos-sprintti 1/2022 Feb 11, 2022
@joelit
Copy link
Contributor Author

joelit commented Apr 1, 2022

There is a ticket number 494568559 about the issue in the service email. It would be nice if we could schedule some time for this.

@osma osma self-assigned this Apr 28, 2022
@osma osma added this to the 2.15 milestone Apr 28, 2022
osma added a commit that referenced this issue Apr 28, 2022
@osma
Use explicit $.parseHTML() to avoid JS syntax error. Fixes #1270
8782ebb
@osma osma mentioned this issue Apr 28, 2022
Merged
3 tasks
Repository owner moved this from Proposed items for this sprint to Issue/PR Closed in Finton Skosmos-sprintti 1/2022 Apr 28, 2022
osma added a commit that referenced this issue Apr 28, 2022
@osma
Use explicit $.parseHTML() to avoid JS syntax error. Fixes #1270
7374d62 
(cherry picked from commit 8782ebb)
@osma
Copy link
Member

osma commented Apr 28, 2022

Fixed in PR #1316, backported to the v2.14-maintenance branch, updated Finto.fi to use the fixed version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osma osma

Labels
bug needs backport
Projects
Finton Skosmos-sprintti 1/2022
Status: Issue/PR Closed
Milestone
2.15
Development

Successfully merging a pull request may close this issue.

Use explicit $.parseHTML() to avoid JS syntax error NatLibFi/Skosmos
2 participants
@joelit @osma