Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error-resistant Vocabulary->getInfo() #1194

Merged
merged 4 commits into from
Sep 8, 2021

Conversation

osma
Copy link
Member

@osma osma commented Sep 7, 2021

This fix has been split off from PR #1033 by creating a new branch from master and cherry-picking a single commit by @kouralex . A merge conflict in concept-shared.twig was fixed.

@osma osma added the bug label Sep 7, 2021
@osma osma added this to the 2.12 milestone Sep 7, 2021
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #1194 (2a912a8) into master (a379eec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1194   +/-   ##
=========================================
  Coverage     68.71%   68.71%           
  Complexity     1598     1598           
=========================================
  Files            32       32           
  Lines          3929     3929           
=========================================
  Hits           2700     2700           
  Misses         1229     1229           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a379eec...2a912a8. Read the comment docs.

@osma osma self-assigned this Sep 7, 2021
@osma
Copy link
Member Author

osma commented Sep 7, 2021

Still need to verify that the translations are OK (especially the Swedish one)

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@osma osma merged commit 7a570ff into master Sep 8, 2021
@osma osma deleted the fix-error-resistant-vocabulary-getinfo branch September 8, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants