Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on symfony/polyfill-php80 to define ValueError #1200

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

osma
Copy link
Member

@osma osma commented Sep 9, 2021

Related to #1170 and especially this comment by @hekl

Skosmos started throwing ValueError exceptions in some situations since PR #1127. However, ValueError was only added in PHP 8, and we are still (mostly) using PHP 7. ValueError still usually worked, because symfony/polyfill-php80 declared it, but it was only available when developmend dependencies were installed.

This PR adds an explicit dependency on symfony/polyfill-php80 also for non-development installs, ensuring that ValueError is always available.

@osma osma added the bug label Sep 9, 2021
@osma osma added this to the 2.12 milestone Sep 9, 2021
@osma osma self-assigned this Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #1200 (e0374ff) into master (7a570ff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1200   +/-   ##
=========================================
  Coverage     68.71%   68.71%           
  Complexity     1598     1598           
=========================================
  Files            32       32           
  Lines          3929     3929           
=========================================
  Hits           2700     2700           
  Misses         1229     1229           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a570ff...e0374ff. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kouralex
Copy link
Contributor

kouralex commented Sep 9, 2021

Works as intended (switches the error from "missing class ValueError" to "Uncaught ValueError").

Can be merged.

@kouralex kouralex self-requested a review September 9, 2021 09:28
@osma osma merged commit fc295e7 into master Sep 9, 2021
@osma osma deleted the fix-valueerror-polyfill-php80-dependency branch September 9, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants