Gracefully produce 404 error page for URLs with unknown vocabulary ID #1215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with URLs containing vocabulary IDs that are unknown to Skosmos. (This includes things like script kiddie attacks looking for WordPress installations and the like.)
Example: https://finto.fi/notfound/ -> produces a blank page and a message in the server error log:
The reason is that the code in index.php attempts catch Exception, but nowadays (since PR #1127) ValueError is produced instead and it is a subclass of Error, not Exception.
This one-line fix changes the catch block to also include ValueError. The end result is that a 404 page is produced instead of a blank page, and nothing gets written into the error log.
(credit to @kouralex for pointing this out)