Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to newest Fuseki 4.4.0 for running unit tests #1273

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

osma
Copy link
Member

@osma osma commented Feb 16, 2022

Reasons for creating this PR

Currently unit tests are set up to run with Fuseki 4.0.0 which is rather old. Upgrading to newest version. This should help ensure that Skosmos stays compatible with current versions of Fuseki. The change affects both GitHub Actions CI as well as tests run locally by developers, as long as they use the init_fuseki.sh script to set up Fuseki.

Link to relevant issue(s), if any

n/a

Description of the changes in this PR

  • upgrade the default Fuseki version in init_fuseki.sh to 4.4.0 (was: 4.0.0)

Known problems or uncertainties in this PR

init_fuseki.sh also supports running the latest SNAPSHET version of Fuseki, by setting the environment variable FUSEKI_VERSION to SNAPSHOT. Some time ago (when we were still using Travis CI) the CI tests also did that. This could be enabled again, but that is out of scope for this PR.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

No new tests needed.

@osma osma added this to the 2.14 milestone Feb 16, 2022
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #1273 (0ee752f) into master (ddf35d7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1273   +/-   ##
=========================================
  Coverage     69.33%   69.33%           
  Complexity     1648     1648           
=========================================
  Files            32       32           
  Lines          4047     4047           
=========================================
  Hits           2806     2806           
  Misses         1241     1241           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddf35d7...0ee752f. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@osma osma merged commit 841dc1b into master Feb 16, 2022
@osma osma deleted the tests-fuseki-4.4.0 branch February 16, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

1 participant