Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin versions of Docker images, update comment #1294

Open
wants to merge 1 commit into
base: skosmos-2
Choose a base branch
from

Conversation

kinow
Copy link
Collaborator

@kinow kinow commented Apr 5, 2022

Reasons for creating this PR

From the linked discussion, looks like Varnish changed the image and now it cannot be used with its default port 80. This pull request pins the versions of the images, instead of using the latest tag, in Docker Compose.

Also updates the commented text to avoid YAML errors.

Link to relevant issue(s), if any

Description of the changes in this PR

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #1294 (e234938) into master (5d193c2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1294   +/-   ##
=========================================
  Coverage     70.68%   70.68%           
  Complexity     1646     1646           
=========================================
  Files            32       32           
  Lines          3786     3786           
=========================================
  Hits           2676     2676           
  Misses         1110     1110           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d193c2...e234938. Read the comment docs.

@kinow
Copy link
Collaborator Author

kinow commented Apr 5, 2022

Also added some troubleshooting notes to the Wiki: https://github.com/NatLibFi/Skosmos/wiki/Install-Skosmos-with-Fuseki-in-Docker#troubleshooting

@kinow kinow force-pushed the pin-docker-image-versions branch from b82a7a2 to e234938 Compare May 24, 2022 09:04
@kinow
Copy link
Collaborator Author

kinow commented May 24, 2022

Rebased.

@sonarcloud
Copy link

sonarcloud bot commented May 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant