-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SKOS-XL tooltips #1317
Fix SKOS-XL tooltips #1317
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1317 +/- ##
============================================
+ Coverage 70.36% 70.68% +0.31%
+ Complexity 1649 1646 -3
============================================
Files 32 32
Lines 3790 3786 -4
============================================
+ Hits 2667 2676 +9
+ Misses 1123 1110 -13
Continue to review full report at Codecov.
|
Rebased and force-pushed. Draft-PR to get test a coverage report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this with a small snippet of DiGA and it seems to work fine!
- Please make sure the
alt
tags are translated, as indicated in the comments. - Please rename the PR so it has a more human-friendly title.
Other than these, looks very good to me!
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Reasons for creating this PR
SKOS-XL tooltips worked only partially; there was a duplicate functionality, which meant that in some parts Skosmos could show only literal values for SKOS-XL tooltips.
Link to relevant issue(s), if any
Description of the changes in this PR
Removed the duplicate functionality. Now also IRI values are displayed in SKOS-XL tooltips.
Known problems or uncertainties in this PR
None.
Checklist