Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SKOS-XL tooltips #1317

Merged
merged 8 commits into from
May 4, 2022
Merged

Fix SKOS-XL tooltips #1317

merged 8 commits into from
May 4, 2022

Conversation

joelit
Copy link
Contributor

@joelit joelit commented May 3, 2022

Reasons for creating this PR

SKOS-XL tooltips worked only partially; there was a duplicate functionality, which meant that in some parts Skosmos could show only literal values for SKOS-XL tooltips.

Link to relevant issue(s), if any

Description of the changes in this PR

Removed the duplicate functionality. Now also IRI values are displayed in SKOS-XL tooltips.

Known problems or uncertainties in this PR

None.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #1317 (e34ba25) into master (a54f285) will increase coverage by 0.31%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##             master    #1317      +/-   ##
============================================
+ Coverage     70.36%   70.68%   +0.31%     
+ Complexity     1649     1646       -3     
============================================
  Files            32       32              
  Lines          3790     3786       -4     
============================================
+ Hits           2667     2676       +9     
+ Misses         1123     1110      -13     
Impacted Files Coverage Δ
model/ConceptPropertyValueLiteral.php 95.65% <80.00%> (+25.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a54f285...e34ba25. Read the comment docs.

@joelit
Copy link
Contributor Author

joelit commented May 3, 2022

Rebased and force-pushed. Draft-PR to get test a coverage report.

@joelit joelit marked this pull request as ready for review May 3, 2022 09:50
@joelit joelit requested a review from osma May 3, 2022 09:51
@joelit joelit added the bug label May 3, 2022
@joelit joelit added this to the 2.15 milestone May 3, 2022
@joelit joelit self-assigned this May 3, 2022
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with a small snippet of DiGA and it seems to work fine!

  • Please make sure the alt tags are translated, as indicated in the comments.
  • Please rename the PR so it has a more human-friendly title.

Other than these, looks very good to me!

view/concept-shared.twig Outdated Show resolved Hide resolved
view/concept-shared.twig Outdated Show resolved Hide resolved
view/concept-shared.twig Outdated Show resolved Hide resolved
@joelit joelit changed the title Issue1263 fix skosxl tooltips Fix SKOS-XL tooltips May 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joelit joelit merged commit d64ceba into master May 4, 2022
@joelit joelit deleted the issue1263-fix-skosxl-tooltips branch May 4, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup for SKOS-XL labels not always populated
2 participants