Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API docs: Add 'uri' parameter to groupMembers #1332

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

danmichaelo
Copy link
Contributor

The uri parameter was listed in https://github.com/NatLibFi/Skosmos/wiki/REST-API#vocidgroupmembers , but seems like it didn't make it over to the swagger format.

@sonarcloud
Copy link

sonarcloud bot commented Jun 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #1332 (1634137) into master (089b8f5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1332   +/-   ##
=========================================
  Coverage     70.68%   70.68%           
  Complexity     1646     1646           
=========================================
  Files            32       32           
  Lines          3786     3786           
=========================================
  Hits           2676     2676           
  Misses         1110     1110           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 089b8f5...1634137. Read the comment docs.

@osma
Copy link
Member

osma commented Jun 23, 2022

The issue that this PR fixes was reported in #1333, already closed.

LGTM, I will merge this now and also add it to the v2.15-maintenance branch.

Thanks a lot @danmichaelo !

@osma osma merged commit 14d24cd into NatLibFi:master Jun 23, 2022
@osma osma added this to the 2.16 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants