Fix header bar search form

[joelit]

Reasons for creating this PR

Cookies are not set correctly for things like multiple vocabulary selection in the global search field. This would break the global search UI element, restricting the use of global search to only skosmos API or writing the search parameters directly to the URL.

Link to relevant issue(s), if any

• Closes Search function does not limit the search to a single vocabulary #1345

Description of the changes in this PR

• scripts.js sets the cookie correctly, using the newly required SameSite attribute (http and https are considered to be different websites)
  • More info: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite
• docready.js reads the selected vocabulary values correctly
• headerbar.twig passes parameter separators correctly

Known problems or uncertainties in this PR

The search vocabulary parameter for "all vocabularies" is not set correctly in the cookie.

Checklist

• phpUnit tests pass locally with my changes
• I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
• The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
• The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

[codecov]

Codecov Report

Merging #1354 (e8715d1) into master (5e6da4b) will increase coverage by 1.24%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1354      +/-   ##
============================================
+ Coverage     70.68%   71.92%   +1.24%     
- Complexity     1646     1831     +185     
============================================
  Files            32       32              
  Lines          3786     3961     +175     
============================================
+ Hits           2676     2849     +173     
- Misses         1110     1112       +2     

Impacted Files	Coverage Δ
model/ConceptPropertyValueLiteral.php	93.87% <0.00%> (-1.78%)	⬇️
model/Concept.php	87.63% <0.00%> (+4.00%)	⬆️
model/LabelSkosXL.php	34.61% <0.00%> (+34.61%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[joelit]

When fixing the language setting for the same menu, it turned out the component which writes the search query url parameters hasn't worked properly beforehand, as the paremeters aren't separeted and the parameter values are not encoded.

Skosmos tries to pre-fill the search query in the text field and fails parsing it.

[osma]

The search vocabulary parameter for "all vocabularies" is not set correctly in the cookie.

I think I know why this happens. Selecting/deselecting options (vocabularies) from the multiselect widget triggers the onChange event, which again calls the updateVocabParam() function that sets the cookie:

Skosmos/resource/js/docready.js

Lines 998 to 1010 in 10d1595

	onChange: function(element, checked) {
	if (element) {
	vocabId = element[0].value;
	} else {
	vocabId = '';
	}
	if (checked && selectedVocabs[vocabId] === undefined) {
	selectedVocabs[vocabId] = vocabId;
	} else if (selectedVocabs[vocabId] !== undefined) {
	delete selectedVocabs[vocabId];
	}
	updateVocabParam();
	},

But onChange is not triggered by the select all option. You need to define a separate onSelectAll event handler.

[osma]

I tested this and couldn't make it not work :) Looks good, apart from the issue that "select all" doesn't set the cookie, which you already noted. I suggested a fix in the above comment. It's also possible to consider that out of scope and file a separate issue about it.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[joelit]

The fix was a pretty simple one; removing the selected vocabularies and calling the updateVocabParam() function seemed to do the trick, as the empty selectedVocabs JS variable and no SKOSMOS_SELECTED value in the cookie is interpreted as having all the vocabularies chosen. :)

[osma]

Looks good and works perfectly! 🎉

Before merging, I suggest changing the PR title to something more descriptive. This fixes many problems related to global search, not just setting cookies.