-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #1389 checking that skosxl properties are only shown for correct language #1425
Conversation
…osxl label language
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1425 +/- ##
============================================
+ Coverage 69.55% 70.08% +0.52%
- Complexity 1650 1658 +8
============================================
Files 32 32
Lines 4257 4272 +15
============================================
+ Hits 2961 2994 +33
+ Misses 1296 1278 -18
☔ View full report in Codecov by Sentry. |
Could you please add a unit test as well? (You have ticked the box, but there is no test.) |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Very good, thanks a lot @henriyli ! I added a |
Cherry-picked the commits to |
Reasons for creating this PR
Bugfix
Link to relevant issue(s), if any
Description of the changes in this PR
Adding a language check for displaying the skosxl properties to prevent showing properties for labels in other than intended language.
Known problems or uncertainties in this PR
Checklist
.sr-only
class, color contrast)