Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations for Skosmos 2.17 release #1569

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

osma
Copy link
Member

@osma osma commented Dec 5, 2023

Reasons for creating this PR

Update to the latest UI translations available on Transifex.

Link to relevant issue(s), if any

Description of the changes in this PR

  • update Spanish translations (by Meron Ewketu)
  • update French translations (by plecor)

Known problems or uncertainties in this PR

The same updates should be done for Skosmos 3 as well.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 2.17 milestone Dec 5, 2023
@osma osma self-assigned this Dec 5, 2023
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b9489a) 70.22% compared to head (5eef18f) 70.22%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1569   +/-   ##
=========================================
  Coverage     70.22%   70.22%           
  Complexity     1665     1665           
=========================================
  Files            32       32           
  Lines          4295     4295           
=========================================
  Hits           3016     3016           
  Misses         1279     1279           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osma osma merged commit b8aa783 into master Dec 5, 2023
10 of 15 checks passed
@osma osma deleted the update-translations-2.17 branch December 5, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo on a Spanish label on the search page
1 participant