don't perform HTML escaping for server constants to avoid breaking alphabetical index for diacritics #1575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
Alphabetical index was broken for diacritics like Ä, Ä, Ö. This happened because of too strict/eager input sanitizing. This PR fixes the problem (on the
master
branch, but notskosmos-3
which may be affected too) by reducing the input sanitizing, just performing escaping of quotes. (I'm not sure that's 100% correct either)Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
skosmos-3
branch and fix it there as wellChecklist
.sr-only
class, color contrast)