Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LOC HTTP prefLabel header parsing case-insensitive (Skosmos 2) #1621

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

osma
Copy link
Member

@osma osma commented Apr 16, 2024

Reasons for creating this PR

Fix LCSH label lookups by making HTTP header parsing case-insensitive. See #1619
This PR backports the fix from Skosmos 3 to Skosmos 2.

Link to relevant issue(s), if any

Description of the changes in this PR

Make LOC HTTP prefLabel header parsing case-insensitive in LOCResolver.php

Known problems or uncertainties in this PR

n/a

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added bug Skosmos 2.X Relevant for Skosmos 2 labels Apr 16, 2024
@osma osma added this to the 2.x milestone Apr 16, 2024
@osma osma self-assigned this Apr 16, 2024
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@osma osma merged commit 822248b into skosmos-2 Apr 16, 2024
9 of 12 checks passed
@osma osma deleted the issue1619-lcsh-label-lookup-skosmos2 branch April 16, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Skosmos 2.X Relevant for Skosmos 2
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

1 participant