Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept type translations for autocomplete search #1631

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joelit
Copy link
Contributor

@joelit joelit commented Apr 25, 2024

Link to relevant issue(s), if any

#1514

Description of the changes in this PR

This PR produces translation strings in WebController for different class URIs. Autocomplete result list can then present human readable labels for the types of search results.

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@joelit joelit added this to the 3.0 milestone Apr 25, 2024
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
28.9% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@osma
Copy link
Member

osma commented Apr 25, 2024

Looks like a good start.

Regarding terminology: I think conceptTypeTranslations or typeTranslations is potentially misleading. Some of the type labels come from translations, others from the vocabulary data. How about typeLabels or just types, depending on the context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Skosmos 3.0 Backlog (not this sprint)
Development

Successfully merging this pull request may close these issues.

2 participants