Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the search language cookie #1720

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joelit
Copy link
Contributor

@joelit joelit commented Dec 12, 2024

Reasons for creating this PR

There was unnecessary state management between URL parameters and language cookies for search language. This PR aims to clarify the situation while fixing a minor bug. Supersedes the previous PR #1693 .

Link to relevant issue(s), if any

Description of the changes in this PR

  • Remove the SKOSMOS_SEARCH_LANG cookie alltogether

Known problems or uncertainties in this PR

None.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@joelit joelit added this to the 3.0 milestone Dec 12, 2024
@joelit joelit self-assigned this Dec 12, 2024
Copy link

sonarcloud bot commented Dec 12, 2024

@joelit joelit marked this pull request as ready for review December 12, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

Content language setting is not working consistently in Skosmos 3
1 participant