Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore 040 change (#188) & Use SKIPPED for updateValidation failures (#189) #190

Merged
merged 5 commits into from
May 25, 2023

Conversation

ammsalme
Copy link
Contributor

  • Ignore f040 change in changeValidation

  • Remove lost file

  • Add tests for coverage

  • Update deps

  • 3.3.8-alpha.1

ammsalme added 2 commits May 17, 2023 09:33
* Ignore f040 change in changeValidation

* Remove lost file

* Add tests for coverage

* Update deps

* 3.3.8-alpha.1
* Use recordStatus SKIPPED instead of ERROR for records failing updateValidation (ie. when incoming record from certain sources has no changes)
** Use detailedRecordStatus SKIPPED_UPDATE for records failing updateValidation
** Use detailedRecordStatus SKIPPED_CHANGE for records failing changeValidation (ie. when skipNoChangeUpdates is active and update would not make any (content) changes in the database record)

* Move getRecord to utils

* Update melinda-rest-api-commons: v4.0.5

* 3.3.9-alpha.2
@ammsalme ammsalme changed the title Ignore 040 change (#188) Ignore 040 change (#188) & Use SKIPPED for updateValidation failures (#189) May 17, 2023
ammsalme added 3 commits May 24, 2023 11:06
* Update marc-record-validators-melinda: v10.8.0
* Update merge-reducers: v2.0.7-alpha.1
* Update deps

* 3.3.9-alpha.3
@ammsalme ammsalme marked this pull request as ready for review May 25, 2023 09:08
@ammsalme ammsalme requested a review from a team as a code owner May 25, 2023 09:08
@ammsalme ammsalme merged commit ac68ba2 into master May 25, 2023
@ammsalme ammsalme deleted the test branch May 25, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant