Upload ONT data to DDS #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssjunnebo
commented
Dec 4, 2024
ssjunnebo
commented
- Get project info from order portal
- Create a delivery project with DDS
- Upload the staged data to DDS
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #449 +/- ##
=========================================
Coverage ? 28.24%
=========================================
Files ? 37
Lines ? 5410
Branches ? 0
=========================================
Hits ? 1528
Misses ? 3882
Partials ? 0 ☔ View full report in Codecov by Sentry. |
alneberg
reviewed
Dec 10, 2024
| @click.option( | ||
| "--order_portal", | ||
| default=None, | ||
| envvar="ORDER_PORTAL", |
There was a problem hiding this comment.
Oh, nice! I didn't know a bout the envvar argument to click!
There was a problem hiding this comment.
@ssjunnebo do you know which has precedence though if you would use the cli argument as well?
There was a problem hiding this comment.
The cli option will take precedence
aanil
reviewed
Dec 10, 2024
aanil
reviewed
Dec 10, 2024
aanil
reviewed
Dec 10, 2024
aanil
approved these changes
Dec 10, 2024
aanil
reviewed
Dec 10, 2024
ssjunnebo
merged commit dc8948e
into
NationalGenomicsInfrastructure:master
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.