Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nsconfig): read app resources path from nsconfig or default #944

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

KristianDD
Copy link
Contributor

@KristianDD KristianDD commented Feb 8, 2018

Create a meaningful title

Read App Resources path from nsconfig.

Description

Part of implementation for NativeScript/nativescript-cli#3257

Related Pull Requests

NativeScript/nativescript-cli#3329
NativeScript/nativescript-cli#3356

@ns-bot
Copy link

ns-bot commented Feb 8, 2018

💚

@KristianDD KristianDD force-pushed the kddimitrov/get-nsconfig-paths branch from 9e35b3f to 9edaaaf Compare February 23, 2018 14:57
@ns-bot
Copy link

ns-bot commented Feb 23, 2018

💔

Copy link
Contributor

@petekanev petekanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go after a passing, green build.

@petekanev
Copy link
Contributor

run ci

@ns-bot
Copy link

ns-bot commented Feb 26, 2018

💔

@petekanev
Copy link
Contributor

run ci

@ns-bot
Copy link

ns-bot commented Feb 26, 2018

💚

@petekanev petekanev merged commit fbdbd5b into master Feb 26, 2018
@petekanev petekanev deleted the kddimitrov/get-nsconfig-paths branch February 26, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants