Support for xcode7 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
force-pushed
the
fatme/sdk-version
branch
from
cce926c to
0131f6f
Compare
| var future = new Future<any>(); | ||
|
|
||
| child_process.exec(command, (error: Error, stdout: NodeBuffer, stderr: NodeBuffer) => { | ||
| //console.log(util.format("Executing: %s", command)); |
There was a problem hiding this comment.
Is this code needed? Can we remove it?
There was a problem hiding this comment.
Yes 😸 We can remove it
teobugslayer
force-pushed
the
fatme/sdk-version
branch
2 times, most recently
from
235af9f to
a255abd
Compare
| import util = require("util"); | ||
| import utils = require("./utils"); | ||
|
|
||
| var $ = require("NodObjC"); |
There was a problem hiding this comment.
you should use nodobjc instead of NodObjC
teobugslayer
force-pushed
the
fatme/sdk-version
branch
from
f714b5a to
3405206
Compare
|
👍 but please update the version so we can publish in npmjs.org |
|
run ci |
Update required node version rules Update version
Fatme
force-pushed
the
fatme/sdk-version
branch
from
9e3d984 to
0249e57
Compare
Remove unneeded code Don't handle watch devices and sdks Polish sdk list
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements NativeScript/nativescript-cli#952