perf: use fast primitive setters (#181)

NativeScript · Nov 30, 2022 · 47c63b0 · 47c63b0
1 parent 796db5a
commit 47c63b0
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 12 deletions.
diff --git a/NativeScript/inspector/JsV8InspectorClient.mm b/NativeScript/inspector/JsV8InspectorClient.mm
@@ -330,10 +330,8 @@
 }
 
 void JsV8InspectorClient::inspectorTimestampCallback(const FunctionCallbackInfo<Value>& args) {
-    Isolate* isolate = args.GetIsolate();
     double timestamp = std::chrono::seconds(std::chrono::seconds(std::time(NULL))).count();
-    Local<Number> result = Number::New(isolate, timestamp);
-    args.GetReturnValue().Set(result);
+    args.GetReturnValue().Set(timestamp);
 }
 
 int JsV8InspectorClient::contextGroupId = 1;

diff --git a/NativeScript/runtime/ArgConverter.mm b/NativeScript/runtime/ArgConverter.mm
@@ -825,12 +825,12 @@
     }
 
     if (obj == nil || obj == [NSNull null]) {
-        args.GetReturnValue().Set(Null(isolate));
+        args.GetReturnValue().SetNull();
         return;
     }
 
     if ([obj isKindOfClass:[@YES class]]) {
-        args.GetReturnValue().Set(v8::Boolean::New(isolate, [obj boolValue]));
+        args.GetReturnValue().Set([obj boolValue]);
         return;
     }
 
@@ -859,7 +859,7 @@
 
     if ([obj isKindOfClass:[NSNumber class]] && ![obj isKindOfClass:[NSDecimalNumber class]]) {
         double value = [obj doubleValue];
-        args.GetReturnValue().Set(Number::New(isolate, value));
+        args.GetReturnValue().Set(value);
         return;
     }
 

diff --git a/NativeScript/runtime/ClassBuilder.mm b/NativeScript/runtime/ClassBuilder.mm
@@ -301,7 +301,7 @@
         });
         class_addMethod(extendedClass, @selector(release), newRelease, "v@:");
 
-        info.GetReturnValue().Set(v8::Undefined(isolate));
+        info.GetReturnValue().SetUndefined();
     }).ToLocalChecked();
 
     PropertyAttribute flags = static_cast<PropertyAttribute>(PropertyAttribute::DontDelete);

diff --git a/NativeScript/runtime/ExtVector.cpp b/NativeScript/runtime/ExtVector.cpp
@@ -41,7 +41,7 @@ void ExtVector::IndexedPropertyGetCallback(uint32_t index, const PropertyCallbac
     ffi_type* ffiType = extVectorWrapper->FFIType();
     if (offset >= ffiType->size) {
         // Trying to access an element outside of the vector size
-        info.GetReturnValue().Set(v8::Undefined(isolate));
+        info.GetReturnValue().SetUndefined();
         return;
     }
 

diff --git a/NativeScript/runtime/InteropTypes.mm b/NativeScript/runtime/InteropTypes.mm
@@ -207,7 +207,7 @@
             std::free(pw->Data());
         }
 
-        info.GetReturnValue().Set(v8::Undefined(isolate));
+        info.GetReturnValue().SetUndefined();
     }).ToLocal(&func);
 
     Isolate* isolate = context->GetIsolate();
@@ -294,7 +294,7 @@
             if (size == 0) {
                 throw NativeScriptException("Unknown type");
             } else {
-                info.GetReturnValue().Set(Number::New(isolate, size));
+                info.GetReturnValue().Set((double)size);
             }
         } catch (NativeScriptException& ex) {
             ex.ReThrowToV8(isolate);

diff --git a/NativeScript/runtime/MetadataBuilder.mm b/NativeScript/runtime/MetadataBuilder.mm
@@ -757,7 +757,7 @@
     std::vector<StructField> fields = structInfo.Fields();
     auto it = std::find_if(fields.begin(), fields.end(), [&propertyName](StructField &f) { return f.Name() == propertyName; });
     if (it == fields.end()) {
-        info.GetReturnValue().Set(v8::Undefined(isolate));
+        info.GetReturnValue().SetUndefined();
         return;
     }
 

diff --git a/NativeScript/runtime/Reference.cpp b/NativeScript/runtime/Reference.cpp
@@ -127,7 +127,7 @@ void Reference::GetValueCallback(Local<v8::Name> name, const PropertyCallbackInf
     Local<Context> context = isolate->GetCurrentContext();
     Local<Value> result = Reference::GetReferredValue(context, info.This());
     if (result.IsEmpty()) {
-        info.GetReturnValue().Set(v8::Undefined(isolate));
+        info.GetReturnValue().SetUndefined();
     } else {
         info.GetReturnValue().Set(result);
     }