fix: only warn once about WeakRef.clear() deprecation. (#140)

NativeScript · Jan 14, 2022 · 7fd4a31 · 7fd4a31
1 parent 9a39108
commit 7fd4a31
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/NativeScript/runtime/WeakRef.cpp b/NativeScript/runtime/WeakRef.cpp
@@ -9,8 +9,13 @@ void WeakRef::Init(Local<Context> context) {
     Isolate* isolate = context->GetIsolate();
 
     std::string source = R"(
-        global.WeakRef.prototype.get = global.WeakRef.prototype.deref; 
+        global.WeakRef.prototype.get = global.WeakRef.prototype.deref;
+        global.WeakRef.prototype.__hasWarnedAboutClear = false;
         global.WeakRef.prototype.clear = () => {
+            if(global.WeakRef.prototype.__hasWarnedAboutClear) {
+                return;
+            }
+            global.WeakRef.prototype.__hasWarnedAboutClear = true;
             console.warn('WeakRef.clear() is non-standard and has been deprecated. It does nothing and the call can be safely removed.');
         }
     )";