Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 8.1 memory leak fixes + readme improvements #123

Merged
merged 21 commits into from
Aug 17, 2021

Conversation

NathanWalker
Copy link
Contributor

No description provided.

triniwiz and others added 19 commits July 3, 2021 10:29
* fix: bool to NSNumber marshalling

* fix: check type encoding
* fix: don't allocate persistent empty objects

* fix: Blocks memory leak (#100)

* feat: drop custom WeakRef implementation & use built-in

* fix: free allocated memory in ReferenceWrapper

* fix: DictionaryAdapter Hanging References (#114)

* Clean up hanging references before deallocating

Reduces total dictionary related memory leaks by 36%

* fix

* chore: more leak fixes

* fix: only release enumerator_ when set (#117)

* fix: handle methods with pointer type params

fixes #109

* fix: referenceWrapper memory leak & CString leak

* refactor: ReferenceWrapper dispose to be managed internally

* fix: pre-allocate memory even for empty values

* fix: undo invalid fix (needs a different way)

Co-authored-by: Darin Dimitrov <darin.dimitrov@gmail.com>
Co-authored-by: Bryse Meijer <brysem@users.noreply.github.com>
Co-authored-by: logikgate <nick.fredricks@flypaper.com>
@cla-bot
Copy link

cla-bot bot commented Aug 11, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @Logikgate.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-bot
Copy link

cla-bot bot commented Aug 11, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @Logikgate.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-bot
Copy link

cla-bot bot commented Aug 11, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @Logikgate.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@NathanWalker NathanWalker merged commit 62dff97 into master Aug 17, 2021
@NathanWalker NathanWalker deleted the fix/memleak-stabilization branch August 17, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants