New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lock isolate before handle_scope #149

Merged

NathanWalker merged 1 commit into release/8-2 from fix/inspector-crash

Mar 3, 2022

Collaborator

edusperoni commented Mar 2, 2022 •

edited

Loading

this fixes a bug where we don't lock the isolate before calling handle_scope, which might make v8 crash.

This crash always happens if you use --debug-brk and try to attach the dev tools


          fix: lock isolate before handle_scope

7069ae6

cla-bot bot added the cla: yes label

edusperoni marked this pull request as ready for review

March 2, 2022 13:04

NathanWalker merged commit d1de7cd into release/8-2

NathanWalker pushed a commit that referenced this pull request


          fix: lock isolate before handle_scope (#149)

3c23fd8

edusperoni deleted the fix/inspector-crash branch

March 9, 2022 11:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels