New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for console log ios 11 on simulator. #76

Merged

Natalia-Hristova merged 1 commit into master from nati/console-log-ios-11-test

Nov 14, 2017

Contributor

Natalia-Hristova commented Nov 3, 2017

Create new test because:

the issue with the missing console log on iOS 11 happened on simulator so couldn't reuse (run_ios_device_tests_ng.py)
to reuse the app that has console.log() - livesync-hello-world-ng
there wasn't test for running ng project on ios simulator

The idea behind not setting the console.log() strings "'Home page loaded!' and 'Application loaded!']" in the initial Tns.wait_for_log(...) is:

to be clear if the test fails - when the reason is the app failure to build/ deploy or the console.log()
the first Tns.wait_for_log() has bigger timeout and when the test fails it takes 3s and when it is in separate check - test fails takes 1s


          Test for console log ios 11 on simulator.

dc6da4d

dtopuzov approved these changes

View reviewed changes

Natalia-Hristova merged commit 106c246 into master

Natalia-Hristova deleted the nati/console-log-ios-11-test branch

November 14, 2017 08:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet