Skip to content

Commit

Permalink
The dev webpack does prepare + run, but run always provided bundle: f…
Browse files Browse the repository at this point in the history
…alse, and triggered incorrect re-prepare
  • Loading branch information
PanayotCankov committed Jun 23, 2017
1 parent 761fc4e commit 6cb7cd9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
5 changes: 3 additions & 2 deletions lib/services/livesync/debug-livesync-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export class DebugLiveSyncService extends LiveSyncService implements IDebugLiveS
$hooksService: IHooksService,
$pluginsService: IPluginsService,
protected $injector: IInjector,
private $options: IOptions,
$options: IOptions,
private $debugDataService: IDebugDataService,
private $projectData: IProjectData,
private $debugService: IDebugService,
Expand All @@ -30,7 +30,8 @@ export class DebugLiveSyncService extends LiveSyncService implements IDebugLiveS
$processService,
$hooksService,
$pluginsService,
$injector);
$injector,
$options);
}

protected async refreshApplication(projectData: IProjectData, liveSyncResultInfo: ILiveSyncResultInfo): Promise<void> {
Expand Down
7 changes: 4 additions & 3 deletions lib/services/livesync/livesync-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ export class LiveSyncService extends EventEmitter implements ILiveSyncService {
private $processService: IProcessService,
private $hooksService: IHooksService,
private $pluginsService: IPluginsService,
protected $injector: IInjector) {
protected $injector: IInjector,
protected $options: IOptions) {
super();
}

Expand Down Expand Up @@ -160,8 +161,8 @@ export class LiveSyncService extends EventEmitter implements ILiveSyncService {
options.preparedPlatforms.push(platform);
// TODO: Pass provision and sdk as a fifth argument here
await this.$platformService.preparePlatform(platform, {
bundle: false,
release: false,
bundle: this.$options.bundle,
release: this.$options.release,
}, null, options.projectData, <any>{}, options.modifiedFiles);
}

Expand Down

0 comments on commit 6cb7cd9

Please sign in to comment.