node_modules is not watched by default

If you want to watch for changes in node_modules or package.json a --sync-all-files or --syncAllFiles flag needs to be passed. By default only the app/ folder is being watched during any livesync.
NativeScript · Feb 3, 2017 · 706a86d · 706a86d
1 parent 99e1ad6
commit 706a86d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/options.ts b/lib/options.ts
@@ -39,7 +39,7 @@ export class Options extends commonOptionsLibPath.OptionsBase {
 			bundle: { type: OptionType.Boolean },
 			all: { type: OptionType.Boolean },
 			teamId: { type: OptionType.String },
-			syncAllFiles: { type: OptionType.Boolean, default: true },
+			syncAllFiles: { type: OptionType.Boolean, default: false },
 			liveEdit: { type: OptionType.Boolean },
 			chrome: { type: OptionType.Boolean },
 			clean: { type: OptionType.Boolean },

diff --git a/lib/services/livesync/livesync-service.ts b/lib/services/livesync/livesync-service.ts
@@ -117,7 +117,11 @@ class LiveSyncService implements ILiveSyncService {
 
 	private partialSync(syncWorkingDirectory: string, onChangedActions: ((event: string, filePath: string, dispatcher: IFutureDispatcher) => void )[]): void {
 		let that = this;
-		let pattern = ["app", "package.json", "node_modules"];
+		let pattern = ["app"];
+		if(this.$options.syncAllFiles) {
+			pattern.push("package.json");
+			pattern.push("node_modules");
+		}
 		let watcher = choki.watch(pattern, { ignoreInitial: true, cwd: syncWorkingDirectory }).on("all", (event: string, filePath: string) => {
 			fiberBootstrap.run(() => {
 				that.$dispatcher.dispatch(() => (() => {