Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tns run/emulate/deploy does not check if device is available before build #1167

Closed
dtopuzov opened this issue Nov 10, 2015 · 1 comment
Closed

tns run/emulate/deploy does not check if device is available before build #1167

dtopuzov opened this issue Nov 10, 2015 · 1 comment
Milestone
1.5.0

Comments

@dtopuzov
Copy link
Contributor

Steps to reproduce:
run/emulate/deploy on not existing device/emulator/simulator

Result:
tns execute prepare and build and after that check if device is available.

Suggestion:
When execute un/emulate/deploy check if device/emulator/simulator before prepare and build.
@dtopuzov dtopuzov added this to the 1.6.0 (Under consideration) milestone Nov 10, 2015
teobugslayer added a commit that referenced this issue Nov 16, 2015
@teobugslayer
Check for devices before building the project
dacbe9b 
See #1167
@teobugslayer teobugslayer mentioned this issue Nov 16, 2015
Closed
@teobugslayer teobugslayer modified the milestones: 1.5.0, 1.6.0 (Under consideration) Nov 16, 2015
teobugslayer added a commit that referenced this issue Nov 16, 2015
@teobugslayer
Check for devices before building the project
cae6c99 
See #1167
@teobugslayer teobugslayer mentioned this issue Nov 16, 2015
Merged
@vchimev vchimev closed this as completed Dec 1, 2015
@vchimev vchimev reopened this Dec 2, 2015
@vchimev vchimev removed this from the 1.5.0 milestone Dec 2, 2015
@vchimev
Copy link

vchimev commented Dec 2, 2015

Done for the run and deploy commands in 1.5.0.

If you execute tns emulate android --device xxxxx it starts the default emulator.
If you execute tns emulate ios --device xxxxx it prepares, builds and finally reports that Unable to find device xxxxx.

Closing this one and updating the relevant: #289.

@vchimev vchimev mentioned this issue Dec 2, 2015
Closed
vchimev pushed a commit to NativeScript/nativescript-cli-tests that referenced this issue Dec 2, 2015
Add tests for the run command.
67ac7f8 
NativeScript/nativescript-cli#1167
@vchimev vchimev closed this as completed Dec 2, 2015
@vchimev vchimev added this to the 1.5.0 milestone Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
4 participants
@teobugslayer @dtopuzov @rosen-vladimirov @vchimev