Livesync typescript #1105
Merged
Livesync typescript #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,8 @@ import Future = require("fibers/future"); | |||
|
|
|||
| export class UsbLiveSyncService extends usbLivesyncServiceBaseLib.UsbLiveSyncServiceBase implements IUsbLiveSyncService { | |||
| private excludedProjectDirsAndFiles = [ | |||
| "app_resources" | |||
| "**/app_resources/**", | |||
There was a problem hiding this comment.
i think it is better to remove this rule entirely. We should let the users to sync their resources.
hdeshev
force-pushed
the
livesync-typescript
branch
from
03886e7 to
c572851
Compare
Fix app_resources too by using the proper **/.../** mask.
|
👍 |
hdeshev
force-pushed
the
livesync-typescript
branch
from
c572851 to
25476f3
Compare
|
Test PASSed. |
|
Fixes #1106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is mostly aimed at fixing the double app restart issue when livesyncing TypeScript projects. The first time you save a
.tsfile it gets synced to the device (completely unnecessarily), then you need another sync after you run your compiler.Changes:
*.tsfiles. No need to livesync them.lib/commonapp_resourcesexclude mask too by using the proper `/app_resources/ form.