Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .ts from tns-core-modules package when moving it to platforms dir #1189

Merged
merged 1 commit into from
Nov 16, 2015

Conversation

rosen-vladimirov
Copy link
Contributor

The new tns-core-modules package has .d.ts files. We should skip them when moving tns-core-modules to platforms dir.
The current logic is - copy everything from node_modules to tns_modules dir.
After that move everything from tns_modules/tns-core-modules dir to tns_modules and delete tns-core-modules.

Add logic to delete .ts files BEFORE moving the files from tns_modules/tns-core-modules dir to tns_modules.

The new tns-core-modules package has .d.ts files. We should skip them when moving tns-core-modules to platforms dir.
The current logic is - copy everything from node_modules to tns_modules dir.
After that move everything from tns_modules/tns-core-modules dir to tns_modules and delete tns-core-modules.

Add logic to delete .ts file BEFORE moving the files from tns_modules/tns-core-modules dir to tns_modules.
@rosen-vladimirov rosen-vladimirov self-assigned this Nov 13, 2015
@rosen-vladimirov rosen-vladimirov added this to the 1.5.0 milestone Nov 13, 2015
@ns-bot
Copy link

ns-bot commented Nov 13, 2015

Test PASSed.

@vchimev
Copy link

vchimev commented Nov 16, 2015

👍

1 similar comment
@Fatme
Copy link
Contributor

Fatme commented Nov 16, 2015

👍

rosen-vladimirov added a commit that referenced this pull request Nov 16, 2015
…modules

Remove .ts from tns-core-modules package when moving it to platforms dir
@rosen-vladimirov rosen-vladimirov merged commit fed257f into release Nov 16, 2015
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/skip-d-ts-core-modules branch November 16, 2015 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants