Simplified creating angular template project #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added angular and ng values for --template option which will use https://github.com/NativeScript/template-hello-world-ng. Added --ng option in the create command which is equal to --template ng and --template angular. Added unit tests. Fix copying hidden files when creating project.
|
ping @ikoevska for the help content |
| } | ||
|
|
||
| if (this.$options.ng) { | ||
| this.$options.template = constants.ANGULAR_NAME; |
There was a problem hiding this comment.
instead of setting this.$options.template you can use something like:
let selectedTemplate = this.$options.ng ? constants.ANGULARE_NAME : this.$options.template;
this.$projectService.createProject(args[0], selectedTemplate).wait();
|
👍 |
TsvetanMilanov
deleted the
milanov/add-angular-and-ng-template-parameters
branch
|
@TsvetanMilanov the docs look good. However, I cannot help but wonder why the TypeScript and Angular syntax differ? Shouldn't the template creation be similar? E.g., either both use "--template tsc/ng" or both are "--tsc/--ng"? |
|
@TsvetanMilanov @ikoevska I logged this here: #1650. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added angular and ng values for --template option which will use https://github.com/NativeScript/template-hello-world-ng.
Added --ng option in the create command which is equal to --template ng and --template angular.
Added unit tests.
Fix copying hidden files when creating project.
Implements #1595