Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message when no plugins found with tns plugin find #1670

Merged
merged 1 commit into from
Apr 7, 2016

Conversation

TsvetanMilanov
Copy link
Contributor

When there are no plugins found with tns plugin find/search command the cli should show message for no plugins found instead of showing empty table with headers.

Fixes #1665 (comment)

@TsvetanMilanov TsvetanMilanov self-assigned this Apr 7, 2016
@TsvetanMilanov TsvetanMilanov added this to the 2.0 milestone Apr 7, 2016
@@ -54,6 +58,8 @@ export class FindPluginsCommand implements ICommand {
let pluginsToDisplay: string[] = allPluginsNames.splice(0, count);
let shouldDisplayMorePlugins: boolean = true;

this.$logger.out("Available NativeScript plugins");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add : at the end.

@rosen-vladimirov
Copy link
Contributor

👍 after green build

When there are no plugins found with tns plugin find/search command the cli should show message for no plugins found instead of showing empty table with headers.
@TsvetanMilanov TsvetanMilanov force-pushed the milanov/fix-plugin-find-empty-result branch from 1d9e77b to de88007 Compare April 7, 2016 08:34
@TsvetanMilanov TsvetanMilanov merged commit 112e117 into master Apr 7, 2016
@TsvetanMilanov TsvetanMilanov deleted the milanov/fix-plugin-find-empty-result branch April 7, 2016 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants