Add a target to the Podfile #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let pluginPodFileContent = this.$fs.readText(pluginPodFilePath).wait(); | ||
| let contentToWrite = this.buildPodfileContent(pluginPodFilePath, pluginPodFileContent); | ||
| this.$fs.appendFile(this.projectPodFilePath, contentToWrite).wait(); | ||
| let contentToWrite = `use_frameworks!\n\ntarget "${this.$projectData.projectName}" do\n${this.buildPodfileContent(pluginPodFilePath, pluginPodFileContent)}\nend`; |
|
👍 after fixing unit tests |
ghost
force-pushed
the
kerezov/cocoa-pods-1.0.0
branch
from
28477e1 to
921663d
Compare
|
but please take care of comments |
ghost
force-pushed
the
kerezov/cocoa-pods-1.0.0
branch
from
921663d to
d8339a3
Compare
Trying to run `pod install` with CocoaPods 1.0.0 issues an error in case the Podfile doesn't reference a target. Add the project target to the Podfile. Upon specifying target to the Podfile, however, the path to the Pods' .xcconfig file changes - reflect that change in code. In addition, truncate and write the Podfile upon each prepare in order to avoid duplication and errors.
|
This PR provides a fix for #1096 also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to run
pod installwith CocoaPods 1.0.0 issues an error in case the Podfile doesn't reference a target. Add the project target to the Podfile.Upon specifying target to the Podfile, however, the path to the Pods' .xcconfig file changes - reflect that change in code.
In addition, truncate and write the Podfile upon each prepare in order to avoid duplication and errors.
Is related to NativeScript/ios-jsc#545
Fixes #1611
Ping @rosen-vladimirov