Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target to Podfile in tns doctor #1771

Merged
merged 1 commit into from
May 19, 2016
Merged

Conversation

Mitko-Kerezov
Copy link
Contributor

CocoaPods 1.0.0 and later requires a target for which the Podfile will install. We already add such a target when preparing the Podfile for projects - extract logic and reuse it in the doctor service.

Fixes #1741
Ping @rosen-vladimirov

@Mitko-Kerezov Mitko-Kerezov added this to the 2.0.1 milestone May 19, 2016
@Mitko-Kerezov Mitko-Kerezov self-assigned this May 19, 2016

if (_.startsWith(projectPodFileContent, podFileHeader)) {
if (_.startsWith(projectPodFileContent, podFileHeader)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ?

@rosen-vladimirov
Copy link
Contributor

👍 after green build

@TsvetanMilanov TsvetanMilanov force-pushed the kerezov/add-target-doctor branch from 9696dcc to 93d56ef Compare May 19, 2016 06:33
CocoaPods 1.0.0 and later requires a target for which the Podfile will install. We already add such a target when preparing the Podfile for projects - extract logic and reuse it in the doctor service.
@Mitko-Kerezov Mitko-Kerezov merged commit 06309b1 into release May 19, 2016
@Mitko-Kerezov Mitko-Kerezov deleted the kerezov/add-target-doctor branch May 19, 2016 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants