delete all unnecessary keys from app/package.json #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run CI |
atanasovg
approved these changes
Dec 13, 2016
hdeshev
approved these changes
Dec 13, 2016
This was referenced Dec 19, 2016
pkoleva
added a commit
to NativeScript/nativescript-cli-tests
that referenced
this pull request
Dec 19, 2016
|
run CI |
Plamen5kov
force-pushed
the
plamen5kov/fix_issue_#2301
branch
from
751a073 to
853c94c
Compare
|
run CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue for more info.
Problem
People get confused because there are two
package.jsonfiles, one in the root folder and one inapp/folder. The twopackage.jsonfiles have the same dependencies and devDependencies, which is the main reason for the confusion.Solution
The solution discussed with @valentinstoychev was to keep the
app/package.jsonas simple as possible, and if possible to add some comments to each key in theapp/package.jsonto explain what is the purpose of it. Because there are no comments in the.jsonformat, IMO it's best to describe the functionality in the documentation.This PR is not final and is only one possible solution. We can decide we want to apply different solution to the problem later on after a discussion. This is simply an easy fix.
Currently we keep only the
name,main,versionandandroidkeys in theapp/package.jsonif anyone thinks we should exclude or include more keys, please comment this PR or this issue.