Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .DS_Store file changes on Mac #2473

Merged
merged 2 commits into from
Feb 6, 2017

Conversation

roblav96
Copy link
Contributor

@roblav96 roblav96 commented Feb 1, 2017

@ns-bot
Copy link

ns-bot commented Feb 1, 2017

Can one of the admins verify this patch?

@roblav96
Copy link
Contributor Author

roblav96 commented Feb 1, 2017

Ye nevermind this didn't resolve the issue :X

@roblav96 roblav96 closed this Feb 1, 2017
@roblav96 roblav96 reopened this Feb 2, 2017
@ns-bot
Copy link

ns-bot commented Feb 2, 2017

Can one of the admins verify this patch?

Copy link
Contributor Author

@roblav96 roblav96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested and can confirm these changes work properly.

Copy link
Contributor

@dtopuzov dtopuzov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 after green tests

@dtopuzov dtopuzov closed this Feb 3, 2017
@dtopuzov dtopuzov reopened this Feb 3, 2017
@ns-bot
Copy link

ns-bot commented Feb 3, 2017

Can one of the admins verify this patch?

@dtopuzov
Copy link
Contributor

dtopuzov commented Feb 3, 2017

run CI

@Plamen5kov Plamen5kov merged commit 11fc089 into NativeScript:master Feb 6, 2017
rosen-vladimirov pushed a commit that referenced this pull request Feb 16, 2017
* Ignore .DS_Store file changes on Mac

https://github.com/paulmillr/chokidar#path-filtering

Resolves:
#2472

* Updated to ignored: '**/*.DS_Store'
rosen-vladimirov added a commit that referenced this pull request Feb 16, 2017
* Ignore .DS_Store file changes on Mac

https://github.com/paulmillr/chokidar#path-filtering

Resolves:
#2472

* Updated to ignored: '**/*.DS_Store'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants