add App_Resources from default template if missing #2513 #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Mar 14, 2017
| @@ -102,6 +104,27 @@ export class ProjectService implements IProjectService { | |||
| this.$fs.createDirectory(path.join(projectDir, "platforms")); | |||
| } | |||
|
|
|||
| private async ensureAppResourcesExist(projectDir: string): Promise<void> { | |||
| let appPath = path.join(projectDir, constants.APP_FOLDER_NAME), | |||
There was a problem hiding this comment.
these could be const instead of let
There was a problem hiding this comment.
I agree const is the better approach. I'll leave it as let now, following the whole style of the file - where all other same-constructed paths are with let. I'll take care to use const in the future :)
| // the template installed doesn't have App_Resources -> get from a default template | ||
| let defaultTemplateName = constants.RESERVED_TEMPLATE_NAMES["default"]; | ||
| await this.$npm.install(defaultTemplateName, projectDir, { save: true, }); | ||
| let defaultTemplateAppResourcesPath = path.join(projectDir, constants.NODE_MODULES_FOLDER_NAME, |
There was a problem hiding this comment.
same here - these could be const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the template specified by the --template parameter doesn't contain the App_Resources folder, we take the App_Resources folder from the default template and use that instead.