Plamen5kov/move emulate to run #2647
Conversation
Plamen5kov
requested review from
yyosifov,
rosen-vladimirov,
TsvetanMilanov and
petekanev
| @@ -10,19 +10,20 @@ Start an emulator and run the app inside it | `$ tns run android --emulator [<Em | |||
| Runs your project on a connected Android device or in a native Android emulator, if configured. This is shorthand for prepare, build and deploy. While your app is running, prints the output from the application in the console and watches for changes in your code. Once a change is detected, it synchronizes the change with all selected devices and restarts/refreshes the application. | |||
|
|
|||
| ### Options | |||
| * `--available-devices` - Shows a list of available emulators to be started and a list of already connected devices. | |||
There was a problem hiding this comment.
this is very very weird to me? So you're telling me I have to run tns run android --available-devices to get the available devices and not run the android app?
There was a problem hiding this comment.
The emulate command had this behavior, and we decided to move the functionality to the run command. If it were up to me, I'd advise the user to use tns device command.
There was a problem hiding this comment.
I agree with @yyosifov, --available-devices should be removed, and users should use tns devices instead. IF you think it would affect users, then put a to-be-deprecated message when --available-devices is used so we can remove it in a following release.
There was a problem hiding this comment.
ok, no problem. Will move the functionality to the tns device command.
| @@ -10,19 +10,20 @@ Start an emulator and run the app inside it | `$ tns run android --emulator [<Em | |||
| Runs your project on a connected Android device or in a native Android emulator, if configured. This is shorthand for prepare, build and deploy. While your app is running, prints the output from the application in the console and watches for changes in your code. Once a change is detected, it synchronizes the change with all selected devices and restarts/refreshes the application. | |||
|
|
|||
| ### Options | |||
| * `--available-devices` - Shows a list of available emulators to be started and a list of already connected devices. | |||
| * `--device` - Specifies a connected device/emulator to start and run the app. | |||
| * `--emulator` - If set, runs the app in all available and configured android emulators. It will start an emulator if none are already running. | |||
There was a problem hiding this comment.
what does "runs the app in all available and configured android emulators"?
There was a problem hiding this comment.
runs app on all running emulators
| * `--available-devices` - Shows a list of available emulators to be started and a list of already connected devices. | ||
| * `--device` - Specifies a connected device/emulator to start and run the app. | ||
| * `--emulator` - If set, runs the app in all available and configured android emulators. It will start an emulator if none are already running. | ||
| * `--justlaunch` - If set, does not print the application output in the console. |
There was a problem hiding this comment.
besides that, this works for both emulator on device right?
I'd suggest: "--justlaunch - when specified starts the application on the emulator/device and omits all the application output in the console"
There was a problem hiding this comment.
besides that, this works for both emulator on device right?
this?
- the
--deviceflag works with emulators/simulators/real devices - the
--emulatorflag works only with emulators/simulators
--justlaunch doesn't start the application, it only cuts off the console, once the application is running.
There was a problem hiding this comment.
That sounds strange to me. My doubt would be what exactly am I launching? Anyway, you can leave it as is for now.
Plamen5kov
force-pushed
the
plamen5kov/move_emulate_to_run
branch
4 times, most recently
from
54d483d to
ba97795
Compare
updated submodule * happy path for android * added comments * fixed tests * fixed emulator by index * call start simulator with id updated docs remove commet removed comment updated submodule added message depricating the emulate command removed tns devices file and added option available-devices to common lib updated docs updated submodule returned starting of emulators to device-service to keep general behavior for all commands using the device updated submodule (reverted tests/refactoring after review) updated submodule (renamings/typo) update submodule (refactoring after review)
Plamen5kov
force-pushed
the
plamen5kov/move_emulate_to_run
branch
from
ba97795 to
b7ea4fd
Compare
do not merge before: telerik/mobile-cli-lib#918
What does this PR do?
related issue: #2349