Fix update #318
Merged
Fix update #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 13, 2015 15:32
|
Test FAILed. |
|
Test PASSed. |
| // Copy old file to options["profile-dir"] | ||
| var sourceFile = path.join(this.platformData.projectRoot, util.format("%s.xcodeproj", this.$projectData.projectName)); | ||
| var destinationFile = path.join(options.profileDir, "xcodeproj"); | ||
| //this.$fs.copyFile(sourceFile, destinationFile).wait(); |
There was a problem hiding this comment.
commented code, consider removing it entirely
|
Test PASSed. |
Fatme
force-pushed
the
fatme/fix-update-1
branch
from
71c0229 to
d8ae20a
Compare
|
Test PASSed. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're copying only framework files. With latest version are released TNSDebugging.framework and Metadata folders as part of framework. This PR changes the logic so that we can update TNSDebugging.framework and Metadata. This PR fixes the case when the old and new xcode projects are different. Also fixes $tns platform update @ and $tns platform add @ commands.
#305