fix: Device logs are not properly shown with debug command #3628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run ci |
The console.log from application should be shown in the terminal when `tns debug <platform>` command is executed. When `tns debug android --start` is used, the console.log messages are not visible as noone has started reading them. Add logic to read and filter them based on the PID of the application. When `tns debug ios [--start]` is used with older runtime (4.0.1 for example) with iOS Simulator, the device logs are not shown as the filtering is based on the projectName, but noone has set this projectName to the filter. So we filter everything. Fix this by setting the projectName to the filter instance. Fix the `tns debug ios --justlaunch` and `tns debug ios --start --justlaunch` which are always printing console.logs, while in fact they shouldn't.
rosen-vladimirov
force-pushed
the
vladimirov/fix-logging
branch
from
bccdc5f to
4e4367a
Compare
Fatme
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The console.log from application should be shown in the terminal when
tns debug <platform>command is executed.When
tns debug android --startis used, the console.log messages are not visible as noone has started reading them. Add logic to read and filter them based on the PID of the application.When
tns debug ios [--start]is used with older runtime (4.0.1 for example) with iOS Simulator, the device logs are not shown as the filtering is based on the projectName, but noone has set this projectName to the filter. So we filter everything. Fix this by setting the projectName to the filter instance.Fix the
tns debug ios --justlaunchandtns debug ios --start --justlaunchwhich are always printing console.logs, while in fact they shouldn't.PR Checklist
What is the current behavior?
Missing console.logs when
tns debug android --startortns debug iosis used.What is the new behavior?
Console.logs are visible.
Fixes:
tns debug android --startreleases the terminal session #2831tns debug android --startdoes not print application console.logs #3629